Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to GitHub Actions. #460

Merged
merged 21 commits into from
Jan 30, 2021
Merged

Migrate to GitHub Actions. #460

merged 21 commits into from
Jan 30, 2021

Conversation

jezdez
Copy link
Member

@jezdez jezdez commented Jan 29, 2021

Travis CI has a new pricing model which places limits on open source.

Many projects are moving to GitHub Actions instead, including Jazzband projects:

This is based on jazzband/contextlib2#26.

It drops support for Python 3.5 because GitHub Actions doesn't fully support it and it's EOL anyway.

It also adds Python 3.9 support and cleans up a bit the packaging setup.

TODO:

  • @jezdez to add JAZZBAND_RELEASE_KEY to the repo secrets.

@codecov
Copy link

codecov bot commented Jan 29, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@8d9b48b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #460   +/-   ##
=========================================
  Coverage          ?   81.24%           
=========================================
  Files             ?       47           
  Lines             ?     1749           
  Branches          ?        0           
=========================================
  Hits              ?     1421           
  Misses            ?      328           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d9b48b...4958872. Read the comment docs.

project/tests/test_view_profiling.py Outdated Show resolved Hide resolved
project/tests/test_view_requests.py Outdated Show resolved Hide resolved
project/tests/util.py Outdated Show resolved Hide resolved
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

Copy link
Member

@nasirhjafri nasirhjafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
I just have one concern, last time I checked Github Actions didn't support PRs from forked repos. Do they support now(if yes do we need to enable some flag too for that)?

@jezdez
Copy link
Member Author

jezdez commented Jan 29, 2021

LGTM 👍

I just have one concern, last time I checked Github Actions didn't support PRs from forked repos. Do they support now(if yes do we need to enable some flag too for that)?

That should be good now, from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/:

In order to protect public repositories for malicious users we run all pull request workflows raised from repository forks with a read-only token and no access to secrets.

But to be on the safe side, I'll try later in a different repo to make sure.

@jezdez
Copy link
Member Author

jezdez commented Jan 29, 2021

LGTM 👍
I just have one concern, last time I checked Github Actions didn't support PRs from forked repos. Do they support now(if yes do we need to enable some flag too for that)?

That should be good now, from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/:

In order to protect public repositories for malicious users we run all pull request workflows raised from repository forks with a read-only token and no access to secrets.

But to be on the safe side, I'll try later in a different repo to make sure.

Ah, no need to do an extra PR, here's a PR that was created from a branch on repo fork: jazzband/django-robots#107

@nasirhjafri nasirhjafri merged commit bef36dc into master Jan 30, 2021
@jezdez jezdez deleted the gha branch January 30, 2021 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants