-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to GitHub Actions. #460
Conversation
Codecov Report
@@ Coverage Diff @@
## master #460 +/- ##
=========================================
Coverage ? 81.24%
=========================================
Files ? 47
Lines ? 1749
Branches ? 0
=========================================
Hits ? 1421
Misses ? 328
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
I just have one concern, last time I checked Github Actions didn't support PRs from forked repos. Do they support now(if yes do we need to enable some flag too for that)?
That should be good now, from https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/:
But to be on the safe side, I'll try later in a different repo to make sure. |
Ah, no need to do an extra PR, here's a PR that was created from a branch on repo fork: jazzband/django-robots#107 |
Travis CI has a new pricing model which places limits on open source.
Many projects are moving to GitHub Actions instead, including Jazzband projects:
This is based on jazzband/contextlib2#26.
It drops support for Python 3.5 because GitHub Actions doesn't fully support it and it's EOL anyway.
It also adds Python 3.9 support and cleans up a bit the packaging setup.
TODO:
JAZZBAND_RELEASE_KEY
to the repo secrets.