Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropped Python 2 support #380

Merged
merged 12 commits into from
Jan 1, 2020
Merged

Dropped Python 2 support #380

merged 12 commits into from
Jan 1, 2020

Conversation

munza
Copy link
Contributor

@munza munza commented Dec 10, 2019

  • Add six package as dependency.
  • Replace django.utils.six with six in source code.
  • Replace the django.utils.decorators.available_attrs with functools.WRAPPER_ASSIGNMENTS by replacing the function call available_attrs(func) with WRAPPER_ASSIGNMENTS

Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep django 2.2+3 support only

requirements.txt Outdated Show resolved Hide resolved
setup.py Outdated
@@ -31,8 +31,6 @@
'Intended Audience :: Developers',
'Operating System :: OS Independent',
'Programming Language :: Python',
'Programming Language :: Python :: 2',
'Programming Language :: Python :: 2.7',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.4',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

drop python 3.4 and add 3.5 3.6 3.7 3.8

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@auvipy, thanks for the suggestion.

@munza munza changed the title Fix Django 3 compatibility issue Dropped Python 2 support Dec 10, 2019
@knyghty knyghty mentioned this pull request Dec 10, 2019
Copy link
Member

@nasirhjafri nasirhjafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@munza Tests are failing, can you please fix them?

@duoi
Copy link
Member

duoi commented Dec 31, 2019

@munza any chance you could take a look at the failing tests?

.travis.yml Outdated
- python: '2.7'
env: DJANGO="Django>=2.1,<2.2.0" DB=mysql DB_NAME=mysql_db
- python: '2.7'
env: DJANGO="Django>=2.2,<2.3.0" DB=mysql DB_NAME=mysql_db
- python: '3.4'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

python 3.4 can also be dropped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, Lemme do that.

docs/index.rst Outdated
@@ -58,4 +58,4 @@ Requirements
------------

* Django: 1.11, 2.0, 2.1, 2.2
* Python: 2.7, 3.4, 3.5, 3.6, 3.7
* Python: 3.4, 3.5, 3.6, 3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.4 should be dropped

Copy link
Member

@nasirhjafri nasirhjafri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 @auvipy Can you please have a look too?

@auvipy auvipy merged commit 7ec97c7 into jazzband:master Jan 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants