-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dropped Python 2 support #380
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep django 2.2+3 support only
setup.py
Outdated
@@ -31,8 +31,6 @@ | |||
'Intended Audience :: Developers', | |||
'Operating System :: OS Independent', | |||
'Programming Language :: Python', | |||
'Programming Language :: Python :: 2', | |||
'Programming Language :: Python :: 2.7', | |||
'Programming Language :: Python :: 3', | |||
'Programming Language :: Python :: 3.4', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drop python 3.4 and add 3.5 3.6 3.7 3.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@auvipy, thanks for the suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@munza Tests are failing, can you please fix them?
@munza any chance you could take a look at the failing tests? |
.travis.yml
Outdated
- python: '2.7' | ||
env: DJANGO="Django>=2.1,<2.2.0" DB=mysql DB_NAME=mysql_db | ||
- python: '2.7' | ||
env: DJANGO="Django>=2.2,<2.3.0" DB=mysql DB_NAME=mysql_db | ||
- python: '3.4' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python 3.4 can also be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, Lemme do that.
docs/index.rst
Outdated
@@ -58,4 +58,4 @@ Requirements | |||
------------ | |||
|
|||
* Django: 1.11, 2.0, 2.1, 2.2 | |||
* Python: 2.7, 3.4, 3.5, 3.6, 3.7 | |||
* Python: 3.4, 3.5, 3.6, 3.7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3.4 should be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 @auvipy Can you please have a look too?
django.utils.six
withsix
in source code.django.utils.decorators.available_attrs
withfunctools.WRAPPER_ASSIGNMENTS
by replacing the function callavailable_attrs(func)
withWRAPPER_ASSIGNMENTS