Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SILKY_MIDDLEWARE_CLASS option #334

Merged
merged 1 commit into from
Mar 12, 2019
Merged

Conversation

vartagg
Copy link
Contributor

@vartagg vartagg commented Mar 2, 2019

Hello. Currently, there is no possibility to subclass the SilkyMiddleware and use it, because profiling._silk_installed always checks for silk.middleware.SilkyMiddleware inclusion in the middleware list. Can I suggest this option?

@mbeacom mbeacom self-assigned this Mar 12, 2019
Copy link
Member

@mbeacom mbeacom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@mbeacom mbeacom merged commit df15c51 into jazzband:master Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants