Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #297 remove explicit byte string from migration 0003 #298

Merged
merged 1 commit into from
Aug 9, 2018
Merged

Fix #297 remove explicit byte string from migration 0003 #298

merged 1 commit into from
Aug 9, 2018

Conversation

florianm
Copy link
Contributor

@florianm florianm commented Aug 9, 2018

Explanation see #297
Dropping the explicit b prefix while unicode_literals are imported will default this string to a unicode string in both Python 2.x and 3.x.
The proposed change was tested under Python 3.6.5 (Anaconda distribution) and Django 2.0.7.

The explicit byte string breaks migrations in Python 3.x.
@avelis avelis merged commit 10e7388 into jazzband:master Aug 9, 2018
@avelis
Copy link
Collaborator

avelis commented Aug 9, 2018

@florianm Thanks for adding this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants