Makes example_app.models.Product.photo.upload_to a string instead of bytes #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
When playing around with some changes to django-silk, I found an error in the example app.
Steps to repro:
Upon saving, the following (truncated) server exception occurred:
It seems like this is down to a simple typo in the 'upload_to' params of example_app.models.Product.photo, passing in bytes instead of a string. I've fixed it in this teeny PR.
I read the Contributing guidelines and the README, but please let me know if I missed something and there's some other way I should be approaching this (like filing an associated issue before sending a PR).
Thanks!