Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make garbage collection filter more efficient #267

Merged
merged 1 commit into from
Jan 29, 2018
Merged

Make garbage collection filter more efficient #267

merged 1 commit into from
Jan 29, 2018

Conversation

albertyw
Copy link
Member

Fixes #261

This switches the garbage collection filter to use start_time instead of id

@albertyw albertyw requested a review from avelis January 28, 2018 23:12
@albertyw albertyw mentioned this pull request Jan 28, 2018
Closed
avelis
avelis approved these changes Jan 29, 2018
View reviewed changes
Copy link
Collaborator

@avelis avelis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe performing a date less that query is more efficient for this deletion than an id in query. Especially for garbage collection.

@avelis avelis merged commit 4576482 into master Jan 29, 2018
@albertyw albertyw deleted the efficient-gc branch February 12, 2018 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avelis avelis avelis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertyw @avelis