Filter out views that took no time in the database for the most time … #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spend in database requests on the dashboard.
|
@albertyw Do you see any potential issues here? |
|
I think this is fine, though a test case would be nice. I'm wondering what requests actually take 0 time; is it a bug that should be fixed? |
albertyw
approved these changes
Dec 5, 2017
|
@albertyw No, this is just a nice trick to filter out the views that have no (NULL) time on the database. Because otherwise they show up at the front because by default NULL are ordered first. |
|
The same trick as actually already used over here: https://github.com/jazzband/silk/blob/master/silk/views/requests.py#L38 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…spend in database requests on the dashboard.
Fixes #217