Updates exception handling to use Django DatabaseError class #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #142 Using Django’s DatabaseError class as the exception to catch keeps the library and this try catch database platform agnostic. That way developers who have a Postgres or MySQL backend should mutually benefit from this retry.
|
@avelis code changes look perfect. Exactly what I was going to do. Travis-CI is complaining about that one test for the 3.4 environment. Same intermittent test that has failed for us before: FAIL: test_time_spent_db_with_path (tests.test_view_requests.TestGetObjects)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/travis/build/django-silk/silk/project/tests/test_view_requests.py", line 98, in test_time_spent_db_with_path
self.assertTrue(num_results)
AssertionError: 0 is not trueSo I think we can ignore that. Unfortunately I'm at the car dealership right now so I only have my work laptop on me but when I get home I can test this branch against the code that was causing the error and report back. Up to you if you want to wait for that or if you wanna just go ahead and merge. Everything looks good to me. |
|
@hanleyhansen I have gone ahead & merged. Thanks for checking on the pull request for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #142
Using Django’s DatabaseError class as the exception to catch keeps the
library and this try catch database platform agnostic. That way
developers who have a Postgres or MySQL backend should mutually benefit
from this retry.