Render function instead of render_to_response #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
May 29, 2016 23:46
|
@auvipy After reading the following stackoverflow question I am ok with merging this in. If you could resolve the failing unit tests In this PR that would be greatly appreciated. |
|
I will try to fix the tests failing first then. |
|
@auvipy I appreciate the effort. I also understand that there might be a failing test not associated to this change. I can be reasonable and expect that test to not get addressed in this PR. |
|
@avelis failed tests are a lot which take time to fix. so i would suggest to merge for now as is. i'm promising to comeback soon with more patches. |
|
@auvipy I have merged in this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the preferred one