Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SILKY_HIDE_COOKIES does not hide cookie header in different case #673

Closed
shtimn opened this issue Sep 8, 2023 · 0 comments · Fixed by #674
Closed

SILKY_HIDE_COOKIES does not hide cookie header in different case #673

shtimn opened this issue Sep 8, 2023 · 0 comments · Fixed by #674

Comments

@shtimn
Copy link
Contributor

shtimn commented Sep 8, 2023

The SILKY_HIDE_COOKIES setting does not hide the cookie header if it is written in a different case.

Current behavior:
When using the SILKY_HIDE_COOKIES setting, the cookie header is not hidden if it is written in a different case compared to the specified name in the code in upper case
Expected behavior:
The SILKY_HIDE_COOKIES setting should hide the cookie header, regardless of the case in which it is written. Currently, it only works if the case matches exactly.

Steps to reproduce:

  1. Set the SILKY_HIDE_COOKIES setting to True.
  2. Send a request with a 'cookie' header in lower case.
  3. Inspect the request headers on the server side, and observe that the 'COOKIE' header is present.

Refs

  • COOKIE in upper case is hardcoded here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant