Skip to content

Package 'autopep8' shouldn't need to be required when installing django-silk #660

Closed
@PabloAlexis611

Description

Since autopep8 is purely for Python code formatting, the installation of autopep8 should be optional/maybe be provided via extras instead. Maybe something like pip install django-silk[dev]

Activity

albertyw

albertyw commented on Jul 9, 2023

@albertyw
Member

django-silk supports generating a python snippet to refire a request -

return autopep8.fix_code(
t.render(Context(context)),
options=autopep8.parse_args(['--aggressive', '']),
)

This python snippet gets run through autopep8 so autopep8 is a runtime dependency of django-silk, not just a test dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      Package 'autopep8' shouldn't need to be required when installing django-silk · Issue #660 · jazzband/django-silk