Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Silk is not compatible with Django 3.1: EmptyResultSet is removed in Django 3.1 #431

Closed
Tirzono opened this issue Aug 4, 2020 · 6 comments · Fixed by #432
Closed

Comments

@Tirzono
Copy link
Contributor

Tirzono commented Aug 4, 2020

https://docs.djangoproject.com/en/3.1/releases/3.1/#id1

  • The compatibility imports of django.core.exceptions.EmptyResultSet in django.db.models.query, django.db.models.sql, and django.db.models.sql.datastructures are removed.
@quimey
Copy link

quimey commented Aug 7, 2020

Are you planning a release with this fix?

@Tirzono
Copy link
Contributor Author

Tirzono commented Aug 7, 2020

I am working on a release PR now, at that point it will be up to @aleksihakli to merge it or not.

@aleksihakli
Copy link
Member

@Tirzono I am not the project maintainer. You can find the maintainers at

https://jazzband.co/projects/django-silk

Only @avelis and @nasirhjafri can release the sites through the Jazzband site to PyPI.

@nasirhjafri
Copy link
Member

I've created a release, It will be published in a while. Thanks @Tirzono and @aleksihakli

@aleksihakli
Copy link
Member

Great, thanks @nasirhjafri!

@nasirhjafri
Copy link
Member

Published to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants