Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect interface for execute_sql #24

Closed
saintger opened this issue Jul 17, 2014 · 1 comment
Closed

Incorrect interface for execute_sql #24

saintger opened this issue Jul 17, 2014 · 1 comment
Labels

Comments

@saintger
Copy link

Hello,

I had some problem related to the function interface of execute_sql in silk/sql.py.

Your interface is:

def execute_sql(self, *args, **kwargs)

With some code to retrieve the result_type keyword:

kwargs.get('result_type', 'multi')

However the interface in Django is different (https://github.com/django/django/blob/master/django/db/models/sql/compiler.py):

def execute_sql(self, result_type=MULTI)

In the case where we call without specifying the keyword:
execute_sql('single')

Your code doesn't give the expected results.

@mtford90
Copy link
Collaborator

You're right. I'll fix this is the next version which will be soon. Cheers.

@mtford90 mtford90 added the bug label Jul 17, 2014
pablodiazgutierrez added a commit to appfluence/django-silk that referenced this issue Oct 18, 2020
…d#24)

* Support for Python3 library in Python2

* Further fixes for Python2

* Another Python2 pitfall in testing for string types

* Python2 valid use of super()

* Dropping parameter specific to Python 3.6

* Typo in comments; this surely refers to the Group, not the User

* Parameterize field 'scim_id' so classes that override SCIMUser and SCIMGroup can use a different field name

* Allow adapters to indicate the lookup_field instead of hardcoding as scim_id

* Define lookup_field as a property to be able to invoke the adapter

* Getting the lookup_field from superclass SCIMView

* Fix: getattr() takes no keyword arguments

* Revert unneeded spacing changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants