-
-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bad requirements for postgres based installations #142
Comments
@hassonofer For now, I suggest to install version |
First of all, thank you very much for the prompt response. I did not test it myself, but as far as I know |
Hi @hassonofer , I'll be home in 30 mins and will try that. It if works I'll put another PR up. I'm sore @avelis will merge it right away so we don't hold you up. Sorry for the inconvenience. |
There is no rush at all, I updated my puppet manifests today to stay on 0.7.0 :) |
@hassonofer Thanks for suggesting a I will also into taking down 1.7.1 from PyPi to avoid others from getting caught into this issue. |
Addresses #142 Using Django’s DatabaseError class as the exception to catch keeps the library and this try catch database platform agnostic. That way developers who have a Postgres or MySQL backend should mutually benefit from this retry.
@hanleyhansen I made a branch to try out a different class in the exception catching. Can you confirm/deny if that works for you? |
Addresses #142 Using Django’s DatabaseError class as the exception to catch keeps the library and this try catch database platform agnostic. That way developers who have a Postgres or MySQL backend should mutually benefit from this retry.
Fixed in release https://github.com/django-silk/silk/releases/tag/0.7.2 |
I forgot to update here, it works great, thanks for everyone who helped. |
After merging #140,
pip install django-silk
fails for postgres based installations.mysqlclient was added as a requirement, which produces the following error (if no mysql installation exist).
The text was updated successfully, but these errors were encountered: