Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement pagination In AdminModel2's list view #355

Open
the5fire opened this issue Jul 28, 2013 · 2 comments
Open

implement pagination In AdminModel2's list view #355

the5fire opened this issue Jul 28, 2013 · 2 comments

Comments

@the5fire
Copy link
Contributor

at https://github.com/pydanny/django-admin2/blob/develop/djadmin2/types.py#L205

I think we need pass list_per_page to index_view(views.ModelListView)

like this:

def get_index_kwargs(self):
    kwargs = self.get_default_view_kwargs()
    kwargs.update({
        'paginate_by': self.list_per_page,
    })
    return kwargs

or something else ?

@pydanny
Copy link
Member

pydanny commented Jul 28, 2013

First go ahead and change the ticket name to be for implementation of this as a feature. Even if AJAX pagination is done, there are going to be themes that will need list view pagination.

Second, what exactly where you trying to link to?

@the5fire
Copy link
Contributor Author

the link just link to where get_index_kwargs will be called in ModelAdmin.

I will start an pull-request later about the pagination in ModelAdmin and themes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants