[direct-linearize] fix name stack tests #26290
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this passes:
See #8395 for an explanation of how the name stack should work. There were three changes we needed to replicate current behavior:
'jvp'
onto the name stack when we trace the function indirect_linearize
;linearize_jaxpr
, be sure to reset the name stack (which was provided intrace_to_jaxpr_dynamic
, butlinearize_jaxpr
doesn't use that and instead uses lower-level stuff).