Skip to content

Conversation

@windmaple
Copy link
Collaborator

Unfortunately Qwix has issues with both the new sharding annotation and KV caching previously added; so I had to revert both.

I also had to re-run the notebook (so that we can get Tunix output), which introduced a lot of metadata and output changes.

Unfortunately Qwix has issues with both the new sharding annotation
and KV caching previously added; so I had to revert both
@windmaple
Copy link
Collaborator Author

windmaple commented Nov 14, 2025

@emilyfertig do you know why the test keeps failing? The notebook runs fine on Colab and these libs are properly installed, so the errors don't make sense to me.

NameError: name 'peft_trainer' is not defined
NameError: name 'tfds' is not defined
ModuleNotFoundError: No module named 'tqdm'

@windmaple
Copy link
Collaborator Author

@emilyfertig can you help me with the 'Unrun reference cell has outputs' errors? I'm a bit lost here. Let's take the first example:

______________ docs/source/JAX_for_LLM_pretraining.ipynb::Cell 1 _______________
Notebook cell execution failed
Cell 1: Unrun reference cell has outputs

Input:
import jax
jax.devices()

We have the nbval-ignore-output tag for this cell. But according to this error, we are skipping this cell but there is a saved ouput, so the error is thrown. So I'm not sure what is happening here.

@emilyfertig
Copy link
Collaborator

I think 'Unrun reference cell has outputs' is because the "execution count" says "null," and the execution count has to be a numeric value (even 0) to resolve the error. I saw that before and it stumped me for a while...

Copy link
Collaborator

@emilyfertig emilyfertig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@windmaple windmaple marked this pull request as ready for review November 26, 2025 08:24
@windmaple
Copy link
Collaborator Author

windmaple commented Nov 26, 2025

Thanks! Finally cleared all errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants