Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add item template function #634

Merged
merged 9 commits into from
Nov 21, 2020
Merged

Add item template function #634

merged 9 commits into from
Nov 21, 2020

Conversation

boidolr
Copy link
Contributor

@boidolr boidolr commented Dec 16, 2018

To further customize item creation it can be useful to have an actual function.
Regardless of whether you'd want to add this functionality the first four commits might be a nice refactoring for the structure of templater.

@javve javve changed the base branch from master to feature/template_function November 21, 2020 19:33
@javve
Copy link
Owner

javve commented Nov 21, 2020

This is a really nice feature @boidolr! Thank you so much and sorry for taking almost two years before I merged it 😳

@DavidBruchmann
Copy link

great, first time since two years I use it, and have to do directly an update 😂

@boidolr boidolr deleted the feature/template_function branch November 22, 2020 11:21
@devgianlu
Copy link

devgianlu commented Apr 8, 2021

I believe this broke .values(newValues), see #698

For a workaround see https://jsfiddle.net/smvhdaq3/

@adriancb
Copy link

Further to @devgianlu's comment, I believe this regressed #438

@Antonio-Bennett
Copy link

Antonio-Bennett commented Nov 14, 2022

+1 to @adriancb. This isn't gonna get fixed anytime soon :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants