Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Subtitles follow-up #197

Closed
raenoll opened this issue Jan 25, 2021 · 11 comments · Fixed by #303
Closed

Feature Request: Subtitles follow-up #197

raenoll opened this issue Jan 25, 2021 · 11 comments · Fixed by #303
Assignees
Labels
enhancement New feature or request

Comments

@raenoll
Copy link

raenoll commented Jan 25, 2021

Expected Behavior

Move subtitles (ABP-001.chi.srt) with movie (ABP-001.mp4) to the same destination path.

srt / ssa / ass / smi

Current Behavior

Do nothing

Your Environment

  • Module version used: 2.2.11
  • Operating System and PowerShell version: debian 10 / PowerShell 7.1.1
@jvlflame jvlflame added the enhancement New feature or request label Jan 27, 2021
@jvlflame jvlflame self-assigned this Jan 28, 2021
@jvlflame
Copy link
Collaborator

Do subtitle files need to be renamed to the same as the movie name?

@raenoll
Copy link
Author

raenoll commented Jan 28, 2021

Do subtitle files need to be renamed to the same as the movie name?

Subtitles of filenames should be the same as the movie name plus ISO language code (2-letter or 3-letter) if available. This fits Plex platform. Emby/Jellyfin may vary.

@jvlflame
Copy link
Collaborator

Could you provide some examples of the subtitle filenames that are included with the movies? If it requires a language code then I assume that will need to be pulled from the filemame.

@raenoll
Copy link
Author

raenoll commented Jan 28, 2021

Could you provide some examples of the subtitle filenames that are included with the movies? If it requires a language code then I assume that will need to be pulled from the filemame.

ABP-001.mp4
ABP-001.chi.ass
ABP-001.jpn.srt
ABP-001.eng.srt

ABP-002.mp4
ABP-002.en.srt
ABP-002.ja.srt
ABP-002.zh.srt

@jvlflame
Copy link
Collaborator

Thanks. So the subtitle files are usually also pulled from the root level of the movie directory as well?
Do you know if there are any cases where the subtitle files are included in a nested folder?

@raenoll
Copy link
Author

raenoll commented Jan 28, 2021

Thanks. So the subtitle files are usually also pulled from the root level of the movie directory as well?

They should be at the same level of directory mostly as far as I know.

Do you know if there are any cases where the subtitle files are included in a nested folder?

I haven't seen this before. Probably for backup in the future if they are in a nested folder because they are unreadable.

Plex / Emby users may use non-standard language codes. In Plex, non-standard language code of subtitle can't be recognized to correct language and converted to unknown language.

@raenoll
Copy link
Author

raenoll commented Feb 5, 2021

In some desktop media players, there may have default settings to read subtitles in subdirectories such as subs, subtitles or custom ones.

@idontknownl
Copy link

Hi jviflame,

I would love to assist in getting this enhancement developed, as It is really bugging me as it takes a lot of time to move the subtitles one by one. Any way I can assist?

I think the easiest implementation could be to expect the user to correctly name the file and have javinizer simply move it in the correct folder during the scan.

@jvlflame
Copy link
Collaborator

@idontknownl Hi there, honestly this probably isn't too hard of a feature to add, but my focus on this project has notably declined since starting to work on other projects. I'll take a look at implementing it in this upcoming week.

@jvlflame
Copy link
Collaborator

@idontknownl In your experience, do the subtitle files come with the standard naming scheme of <MOVIE>.<LANG>.<EXT> that @raenoll provided above? If so, I can add a blanket check for the language in the filename, otherwise it may get more complicated. I'd rather the user not have to rename the subtitle files themselves so I'm hoping that the downloaded subtitles are consistently named.

ABP-001.mp4
ABP-001.chi.ass
ABP-001.jpn.srt
ABP-001.eng.srt

ABP-002.mp4
ABP-002.en.srt
ABP-002.ja.srt
ABP-002.zh.srt

@idontknownl
Copy link

I jvflame, indeed I easily added the subtitle format I was interested (i am using ASS) to your script, so it recognizes, renames, and allocates it in the correct folder, It is not elegant but it works. the only issue as you pointed out above I lose the language code (but I am not interested in multiple languages at this time so is fine).
The format depends on who makes the subtitle but that is the standard format that is recognized by plex/kodi etc otherwise the subtitle will not be automatically associated.

jvlflame added a commit that referenced this issue Sep 26, 2021
jvlflame added a commit that referenced this issue Sep 28, 2021
@jvlflame jvlflame mentioned this issue Sep 28, 2021
jvlflame added a commit that referenced this issue Sep 28, 2021
@jvlflame jvlflame linked a pull request Sep 28, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants