Skip to content

Remove programatic height #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Conversation

GantMan
Copy link
Contributor

@GantMan GantMan commented Dec 14, 2020

When you upload a JSON file the text height is zero, so this sets textarea heights to zero.

While it works great while live editing, a loaded JSON file when edited gets set to zero.

Screen Shot 2020-12-13 at 10 09 59 PM

When you upload a JSON file the text height is zero, so this sets textarea heights to zero.
@GantMan
Copy link
Contributor Author

GantMan commented Dec 14, 2020

If this is used somewhere (I see there's a different spot that uses a similar function), I can change it to just set min-height so this error goes away. But I figured remove the issue if the code isn't doing anything.

@steveoni steveoni merged commit 10ce942 into javascriptdata:master Jan 22, 2021
@GantMan GantMan deleted the patch-1 branch January 22, 2021 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants