Skip to content
This repository was archived by the owner on Mar 22, 2020. It is now read-only.

Commit 32943d3

Browse files
committed
minor
1 parent f6c4a25 commit 32943d3

File tree

3 files changed

+25
-13
lines changed

3 files changed

+25
-13
lines changed

lib/init/Readme.template.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@ Please help us to make the translation better.
99
- Add a comment to that issue to inform the maintainer that you're translating it.
1010
- Fork the repository, translate and send a PR when done.
1111

12+
Also let others know what you're translating, in message boards or chats in your language. Invite them to join!
13+
1214
🎉 Thank you!
1315

1416
<% if (langInfo.published) { -%>

lib/sync.js

Lines changed: 23 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -87,26 +87,36 @@ Please fix the conflicts by pushing new commits to this pull request, either by
8787
conflictList = 'No conflicts were found.';
8888
}
8989

90+
let tips = '';
91+
if (conflictList) {
92+
tips = `
93+
We recommend to merge conflicting changes manually and close this PR.
9094
91-
const body = `
92-
This PR was automatically generated.
93-
Merge changes from [en.javascript.info](https://github.com/${config.org}/${config.langMain}.${config.repoSuffix}/commits/master) at ${shortHash}
94-
95-
${conflictList}
96-
97-
You can also close this PR and merge the changes manually:
98-
1. \`git add remote upstream https://github.com/javascript-tutorial/en.javascript.info\`
95+
The steps are:
96+
1. Setup upstream (if haven't yet)
97+
- \`git add remote upstream https://github.com/javascript-tutorial/en.javascript.info\`
9998
2. Commit all current work and \`git checkout master\`
100-
3. Pull from the English version \`git pull upstream master\`
101-
4. Deal with the conflicts. If there are many changes in a file, e.g. \`README.md\`, then you could:
99+
3. Pull the recent changes from the English version:
100+
- \`git pull upstream master\`
101+
4. Deal with the conflicts. If a conflict touches a few lines, then just fix them. Otherwise, if there are many changes, you can see them like this:
102102
- Checkout your version, \`git checkout --ours README.md\`
103103
- See what changed in the original file:
104-
- \`git diff --word-diff master...upstream/master README.md\` (three dots)
105-
- Update your version
106-
- \`git commit -m synced README.md\`
104+
- \`git diff --word-diff master...upstream/master README.md\` (please note: three dots in the command)
105+
- Re-translate or otherwise sync the translated version and commit it:
106+
- \`git commit -m synced README.md\`
107107
5. When conflicts resolved, \`git push origin master\`
108108
109109
P.S. **Don't squash and merge** if GitHub offers you, as this leads to same conflicts re-appear in the future.
110+
`;
111+
}
112+
113+
const body = `
114+
This PR was automatically generated.
115+
Merge changes from [en.javascript.info](https://github.com/${config.org}/${config.langMain}.${config.repoSuffix}/commits/master) at ${shortHash}
116+
117+
${conflictList}
118+
119+
${tips}
110120
`;
111121

112122
try {

template/progress.md.pug

Whitespace-only changes.

0 commit comments

Comments
 (0)