Edit typos in article.md #30
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's wrong with 'From the other hand' ? Are you a native speaker (if I may ask) ? |
|
No, I'm not but my English is decent. Also, the expression that is usually used is 'on the other hand'. I haven't heard of 'from the other hand' used in that context. That being said, it's a simple grammatical error and doesn't affect what's being put across in anyway so it's pretty minor. |
|
I hope a native speaker will look at the PR and give a feedback. If you are reading this -- please, do :) |
|
Made some research, I think you're right, thank you, merging in! |
|
Haha, no problem man. Always happy to help. |
athena0304
pushed a commit
to athena0304/javascript-tutorial-en
that referenced
this pull request
Jun 4, 2018
* Transfer the existing translation, ready for review Co-authored-by: maoxiaoke <thebigyellowbee@qq.com> resolve javascript-tutorial#2 * fix(hello-world): Adjust some contents * translate more contents * 👌 fix: Adjust some words due to code review changes Signed-off-by: sqrtthree <imsqrtthree@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.