fix: sonar

Author: Vihas Splunk

src/main/java/com/splunk/hecclient/ConcurrentHec.java

@@ -74,7 +74,6 @@ public final void close() {
         }
 
         stopped = true;
-        // executorService.shutdownNow();
         executorService.shutdown();
     }
 

src/main/java/com/splunk/hecclient/Indexer.java

@@ -272,7 +272,7 @@ private String readAndCloseResponse(CloseableHttpResponse resp) {
 
             String respText = (jsonNode.has("text")) ? jsonNode.get("text").asText() : null;
 
-            if (respText == "Invalid data format") {
+            if (respText.equals("Invalid data format")) {
                 ObjectNode objNode = jsonMapper.createObjectNode();
                 objNode.put("text", "Invalid data format");
                 objNode.put("code", 0); // Mark it as success

src/main/java/com/splunk/hecclient/JsonEventBatch.java

@@ -57,7 +57,7 @@ public int hashCode() {
     public boolean equals(Object obj) {
         if (obj instanceof JsonEventBatch) {
             final JsonEventBatch other = (JsonEventBatch) obj;
-            return endpoint.equals(endpoint);
+            return obj.equals(other);
         }
         return false;
     }

src/main/java/com/splunk/kafka/connect/SplunkSinkTask.java

@@ -71,7 +71,7 @@ public void start(Map<String, String> taskConfig) {
         tracker = new KafkaRecordTracker();
         bufferedRecords = new ArrayList<>();
         if(connectorConfig.flushWindow > 0) {
-            flushWindow = connectorConfig.flushWindow * 1000; // Flush window set to user configured value (Multiply by 1000 as all the calculations are done in milliseconds)
+            flushWindow = connectorConfig.flushWindow * Long.valueOf(1000); // Flush window set to user configured value (Multiply by 1000 as all the calculations are done in milliseconds)
         }
 
         log.info("kafka-connect-splunk task starts with config={}", connectorConfig);
@@ -569,8 +569,7 @@ private void timestampExtraction(Event event) {
 
         if (connectorConfig.timestampFormat.equalsIgnoreCase("epoch")) {
             try {
-                double epoch;
-                epoch = ((Double.parseDouble(timestamp)));
+                double epoch = (Double.parseDouble(timestamp));
                 long long_epoch = Double.valueOf(epoch).longValue();
                 event.setTime(epoch / (Math.pow(10, Long.toString(long_epoch).length()-10.00)));