name[] rather than names[] for series filtering.

Fix vertx implementation.

Author: brian-brazil

simpleclient_servlet/src/main/java/io/prometheus/client/exporter/MetricsServlet.java

@@ -48,7 +48,7 @@ protected void doGet(final HttpServletRequest req, final HttpServletResponse res
   }
 
   private Set<String> parse(HttpServletRequest req) {
-    String[] includedParam = req.getParameterValues("names[]");
+    String[] includedParam = req.getParameterValues("name[]");
     if (includedParam == null) {
       return Collections.emptySet();
     } else {

simpleclient_servlet/src/test/java/io/prometheus/client/exporter/MetricsServletTest.java

@@ -30,7 +30,7 @@ public void testWriterFiltersBasedOnParameter() throws IOException, ServletExcep
     Gauge.build("c", "a help").register(registry);
 
     HttpServletRequest req = mock(HttpServletRequest.class);
-    when(req.getParameterValues("names[]")).thenReturn(new String[]{"a", "b", "oneTheDoesntExist", ""});
+    when(req.getParameterValues("name[]")).thenReturn(new String[]{"a", "b", "oneTheDoesntExist", ""});
     HttpServletResponse resp = mock(HttpServletResponse.class);
     StringWriter stringWriter = new StringWriter();
     PrintWriter writer = new PrintWriter(stringWriter);

simpleclient_spring_boot/src/main/java/io/prometheus/client/spring/boot/PrometheusMvcEndpoint.java

@@ -28,7 +28,7 @@ public PrometheusMvcEndpoint(PrometheusEndpoint delegate) {
   )
   @ResponseBody
   public ResponseEntity value(
-          @RequestParam(value = "names[]", required = false) Set<String> name) {
+          @RequestParam(value = "name[]", required = false) Set<String> name) {
     if (!getDelegate().isEnabled()) {
       // Shouldn't happen - MVC endpoint shouldn't be registered when delegate's
       // disabled

simpleclient_spring_boot/src/test/java/io/prometheus/client/spring/boot/PrometheusEndpointTest.java

@@ -47,7 +47,7 @@ public void testMetricsExportedThroughPrometheusEndpoint() {
     // when:
     promCounter.labels("val1", "val2").inc(3);
     filteredCounter.labels("val1", "val2").inc(6);
-    ResponseEntity<String> metricsResponse = template.getForEntity(getBaseUrl() + "/prometheus?names[]=foo_bar", String.class);
+    ResponseEntity<String> metricsResponse = template.getForEntity(getBaseUrl() + "/prometheus?name[]=foo_bar", String.class);
 
     // then:
     assertEquals(HttpStatus.OK, metricsResponse.getStatusCode());

simpleclient_vertx/src/main/java/io/prometheus/client/vertx/MetricsHandler.java

@@ -10,7 +10,6 @@
 import java.io.IOException;
 import java.io.Writer;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.HashSet;
 import java.util.Set;
 
@@ -85,11 +84,6 @@ public void handle(RoutingContext ctx) {
   }
 
   private Set<String> parse(HttpServerRequest request) {
-    String includedParam = request.getParam("names[]");
-    if (includedParam == null) {
-      return Collections.emptySet();
-    } else {
-      return new HashSet<String>(Arrays.asList(includedParam.split(",")));
-    }
+    return new HashSet(request.params().getAll("name[]"));
   }
 }

simpleclient_vertx/src/test/java/io/prometheus/client/exporter/MetricsHandlerTest.java

@@ -57,7 +57,7 @@ public void metricsRequest_shouldReturnMetrics() throws IOException {
 
   @Test
   public void metricsRequest_shouldAllowFilteringMetrics() throws IOException {
-    String out = makeRequest("/metrics?names[]=b,c");
+    String out = makeRequest("/metrics?name[]=b&name[]=c");
 
     assertThat(out).doesNotContain("a 0.0");
     assertThat(out).contains("b 0.0");