Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete release 2.9.5 #142

Closed
2 tasks done
pietrygamat opened this issue Aug 9, 2023 · 6 comments
Closed
2 tasks done

Complete release 2.9.5 #142

pietrygamat opened this issue Aug 9, 2023 · 6 comments

Comments

@pietrygamat
Copy link
Collaborator

pietrygamat commented Aug 9, 2023

I have prepared the relase according to
https://github.com/java-native/jssc/wiki/Publishing-a-Release

Before releasing to maven central, let's do some additional testing

Github pre-release with "fat" jar:
https://github.com/java-native/jssc/releases/tag/v2.9.5

Maven staging repo (add this to pom to test with newest version with maven):

<dependencies>
    <dependency>
        <groupId>io.github.java-native</groupId>
        <artifactId>jssc</artifactId>
        <version>2.9.5</version>
    </dependency>
</dependencies>
<repositories>
    <repository>
        <id>jssc-staging</id>
        <url>https://oss.sonatype.org/content/repositories/iogithubjava-native-1016</url>
    </repository>
</repositories>

Tasks to do

  • Update Release notes
  • Release from sonatype staging nexus to maven central
@pietrygamat
Copy link
Collaborator Author

@tresf please find some time to review the draft release, and if you are satisfied, promote it to full release on Github. I'll then push follow up with maven central.

@tresf
Copy link

tresf commented Aug 9, 2023

@pietrygamat I'd be happy to real-world test the 2.9.5 version but I don't currently have a project using JSSC with Maven to test with. Are you OK if I simply test the fat jars?

@pietrygamat
Copy link
Collaborator Author

@tresf of course. I do have maven projects for Windows and Linux so I am pretty confident about this part. It's the native libs vs OS architectures that kill my self esteem every time :D.

@tresf
Copy link

tresf commented Aug 9, 2023

Ok, I'll have Intel testing on real hardware done soon per another project qzind/tray#1165 and report my findings.

@tresf
Copy link

tresf commented Aug 9, 2023

@tresf please find some time to review the draft release

In regards to the release description, the only feedback that I have is that it's slightly redundant to mention both a bug report and a pull request for a bulleted item, however, I will list several bug reports on a line to illustrate popularity for fixes or features that were requested multiple times or span a wider range of issues.

The rest looks great, thank you.

Minor clarification in javadoc: #73 #119
^--- I would probably just list the bug report in this instance.

@tresf
Copy link

tresf commented Aug 11, 2023

Ok, I'll have Intel testing on real hardware done soon per another project qzind/tray#1165 and report my findings.

Testing passed.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants