Improved mode validation of brightness, added validation override

Author: jath03

openrgb/orgb.py

@@ -1,11 +1,11 @@
 from __future__ import annotations
 import struct
 import platform
+import warnings
 from openrgb import utils
 from typing import Union, Any, Optional
 from openrgb.network import NetworkClient
 from openrgb.plugins import create_plugin, ORGBPlugin
-from time import sleep
 from os import environ
 
 
@@ -294,7 +294,7 @@ def set_colors(self, colors: list[utils.RGBColor], fast: bool = False):
         elif active_mode.color_mode == utils.ModeColors.PER_LED:
             self._set_device_colors(colors, fast)
 
-    def set_mode(self, mode: Union[str, int, utils.ModeData], save: bool = False):
+    def set_mode(self, mode: Union[str, int, utils.ModeData], save: bool = False, force: bool = False):
         '''
         Sets the device's mode
 
@@ -313,7 +313,13 @@ def set_mode(self, mode: Union[str, int, utils.ModeData], save: bool = False):
             pass
         else:
             raise TypeError()
-        data = mode.pack(self.comms._protocol_version)  # type: ignore
+        try:
+            data = mode.pack(self.comms._protocol_version)  # type: ignore
+        except ValueError as e:
+            if force:
+                warnings.warn(str(e))
+            else:
+                raise e
         self.comms.send_header(
             self.id,
             utils.PacketType.RGBCONTROLLER_UPDATEMODE,

openrgb/utils.py

@@ -259,7 +259,7 @@ def validate(self, version: int):
             if ModeFlags.HAS_MODE_SPECIFIC_COLOR in self.flags:
                 assert self.colors_min <= len(self.colors) <= self.colors_max  # type: ignore
             if ModeFlags.HAS_BRIGHTNESS in self.flags and version >= 3:
-                assert self.brightness_min <= self.brightness <= self.brightness_max  # type: ignore
+                assert self.brightness_min <= self.brightness <= self.brightness_max or self.brightness_max <= self.brightness <= self.brightness_min  # type: ignore
         except AssertionError as e:
             raise ValueError("Mode validation failed.  Required values invalid or not present") from e