[DRAFT] Validate pattern/palette index with hash #234
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Uses MurMurHash3, a non-cryptographic hash that appears to decently hash short text
|
@jasoncoon -- Just wanted to see if there's interest in either of the two parts of this:
I've not yet figured a way to reliably debug on ESP8266, which is the only known issue holding this up. Testing is non-trivial. |
|
I wasn't overly concerned about either of these problems, but I have no problem with fixing them or this solution. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #230 ... at least in part ... by ensuring that a hash of the name for the palette and pattern match the value stored in EEPROM.
Used MurMurHash3 for speed and applicability to hashing strings in non-security context.