Debug of issue #871 #907
Merged
Debug of issue #871 #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbgl
reviewed
Sep 18, 2024
vbgl
reviewed
Sep 18, 2024
vbgl
force-pushed
the
debug-issue-#871
branch
from
9ebf1fa
to
1a74ce6
Compare
vbgl
force-pushed
the
debug-issue-#871
branch
from
1a74ce6
to
ec0dd17
Compare
vbgl
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PrintASM.format_glob_datafunction was able to write the same label multiple times, causing the produced assembly code to be incorrect.By adding a Map to count occurrences of the same variable, the problem is corrected.
There is a test to write (for example the file written by @vbgl in the issue). I wasn't sure where to put it so I didn't (We will need to add it before merging).