Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to lower-spill #836

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Improvements to lower-spill #836

merged 4 commits into from
Jun 13, 2024

Conversation

bgregoir
Copy link
Contributor

@bgregoir bgregoir commented Jun 12, 2024

  • The lower-spill transformation only skips functions in which no #spill or #unspill operation appear (fixes Unexpected operator unspill #719)
  • This transformation introduces assignment without a flag: this allows the following passes (in particular dead-code-elimination) to remove them when appropriate.

@vbgl vbgl added this to the 2024.06.0 milestone Jun 12, 2024
@vbgl vbgl changed the title Fix #719 Improvements to lower-spill Jun 12, 2024
vbgl
vbgl previously approved these changes Jun 12, 2024
@eponier
Copy link
Contributor

eponier commented Jun 12, 2024

I have small improvements to push too. Give me 3 minutes.

Copy link
Member

@vbgl vbgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is everybody satisfied with the current state of this PR?

Copy link
Contributor

@eponier eponier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me.

@bgregoir
Copy link
Contributor Author

Ok with me, thank for all the improvements

@vbgl vbgl merged commit c95cebc into main Jun 13, 2024
1 check passed
@vbgl vbgl deleted the fix-#719 branch June 13, 2024 08:33
clebreto pushed a commit that referenced this pull request Jul 18, 2024
 - The lower-spill transformation only skips functions in which no `#spill` or `#unspill` operation appear (fixes #719)
 - This transformation introduces assignment without a flag: this allows the following passes (in particular dead-code-elimination) to remove them when appropriate.

Co-authored-by: Vincent Laporte <Vincent.Laporte@inria.fr>
Co-authored-by: Jean-Christophe Léchenet <jean-christophe.lechenet@inria.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected operator unspill
3 participants