Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add x86 instructions RORX, SARX, SHRX, SHLX #824

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Add x86 instructions RORX, SARX, SHRX, SHLX #824

merged 1 commit into from
Jun 10, 2024

Conversation

vbgl
Copy link
Member

@vbgl vbgl commented Jun 5, 2024

Shifts & rotations that:

  1. do not affect flags
  2. may have different source & destination

bgregoir
bgregoir approved these changes Jun 6, 2024
View reviewed changes
Copy link
Contributor

@bgregoir bgregoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By curiosity, did you run your fuzzing on it ?

@vbgl
Copy link
Member Author

vbgl commented Jun 6, 2024

No. Randomized test of the semantics of instructions currently only works for ARM. Moreover, there is no satisfying method for sampling arguments that are immediate values (such as last operand of RORX).

@bgregoir bgregoir merged commit a7c5db0 into main Jun 10, 2024
1 check passed
@bgregoir bgregoir deleted the bmishift branch June 10, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bgregoir bgregoir bgregoir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vbgl @bgregoir