Safety-checker: support for SLH primitives #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgregoir
reviewed
Jun 3, 2024
| let msf = Pif (Bty (U U64), b, msf, pcast U64 (Pconst (Z.of_int (-1)))) in | ||
| [ Some msf ] | ||
| | SLHmove -> let msf = as_seq1 es in [ Some msf ] | ||
| | SLHprotect _ | SLHprotect_ptr _ -> |
There was a problem hiding this comment.
This is suspicious, what about protect(x, -1)? I think you assume that the program is well typed for SCT.
There was a problem hiding this comment.
What’s the semantics of #protect?
There was a problem hiding this comment.
You are right, I forgot that the semantic of protect is the identity at source level.
Sorry for that.
There was a problem hiding this comment.
This program is well-typed and has a well-defined semantics (the identity). However, it cannot be compiled.
export
fn p(reg u64 x) -> reg u64 {
reg u64 y msf;
msf = 42;
y = #protect(x, msf);
return y;
}
bgregoir
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #670