-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liveness: improve for register allocation #469
Conversation
I don't get the idea of the second commit. I have the impression that we are less precise than before, and it gives better results? |
Yes, I don’t really understand why we had this special case… |
Without this change, when there is Maybe I could fix that instead… |
With this patch, the compiler would generate a dead Maybe it’s better to just crash… |
I think this change is good: it simplifies code that is unnecessarily complex. |
let asmOp = Arch_extra.asm_opI X86_arch_full.X86_core.asm_e in | ||
FSPa.fs_pa_make asmOp is_move_op PW.main | ||
FSPa.fs_pa_make asmOp PW.main | ||
|
||
(* We compute the reflexive and transitive clojure of dp *) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not so frequent that I am able to find a typo in a comment (clojure -> closure) :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
unless it is dummy
This somehow reverts commit 72d20a6 Co-authored-by: Benjamin Grēgoire <Benjamin.Gregoire@inria.fr>
Fixes #455