Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for _.find. #617

Merged
merged 2 commits into from
May 26, 2012
Merged

Add tests for _.find. #617

merged 2 commits into from
May 26, 2012

Conversation

michaelficarra
Copy link
Collaborator

@braddunbar
Copy link
Collaborator

This looks great, but aren't the tests backwards? The signature for equal is (actual, expected, message) and 3/void 0 is the expected value, not the actual value. Also, we should probably use strictEqual here (we should likely use strictEqual in many more places).

@michaelficarra
Copy link
Collaborator Author

Fixed.

@braddunbar
Copy link
Collaborator

Beautiful, thanks! :)

braddunbar added a commit that referenced this pull request May 26, 2012
@braddunbar
Merge pull request #617 from michaelficarra/patch-3
99d1023 
Add tests for `_.find`.
@braddunbar braddunbar merged commit 99d1023 into jashkenas:master May 26, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelficarra @braddunbar