Repository navigation
Conversation
Collaborator
Author
There was a problem hiding this comment.
Let me know if the old way is preferred
Old way:
keys = _.map(concat.apply([], slice.call(arguments, 1)), String);
iterator = function(value, key) { return !_.contains(keys, key); };
Collaborator
Author
There was a problem hiding this comment.
http://jsperf.com/invert-vs-map which should be used for this case?
Owner
Feel like showing it in a little JSPerf? |
Use a pickerCreator function to create omit and pick
Collaborator
Author
|
I updated the pr from the original commit to be faster for the arguments case (slightly less terse now). |
Contributor
|
This looks like a mixed bag across browsers. I don't see a clear win for this change. |
Collaborator
|
...not to mention the added complexity. I rather prefer them separate. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a function generator to create
_.pickand_.omitas they're essentially the same function.We can expect a major performance improvement from this changeset for all cases of
_.omitwith some perf hit on the properties as argument case for_.pick