Always pop pushed elements from the stack #1011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the constructor checks returned early which would prevent the most recently pushed elements from being popped from the stacks. Now result is set to false so the the pop lines are still reached after the constructor checks are done.
|
Eh? I'm afraid I can't merge this without a test proving that the behavior here is being changed in a beneficial way. Mind adding one? |
|
... I guess not. |
|
His patch is good advice anyways. I avoid it in Lo-Dash by simply exiting before the stack push. |
jashkenas
added a commit
that referenced
this pull request
Jul 6, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the constructor checks returned early which would prevent the most recently pushed elements from being popped from the stacks.
Now result is set to false so the the pop lines are still reached after the constructor checks are done.