Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: not attempt strategy more than one time #987

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Sczlog
Copy link

@Sczlog Sczlog commented Jun 15, 2023

Background

some strategy doesn't handle error well which call strategy.fail multiple time in one strategy, which make the next strategy(if exist) will be called multiple times unexpected.

Change

this pr attend to limit one strategy should only be attempt once, as code not support es6, use object to store attmepted strategy's order and skip if was already attempted

Checklist

  • I have read the CONTRIBUTING guidelines.
  • I have added test cases which verify the correct operation of this feature or patch.
  • I have added documentation pertaining to this feature or patch.
  • The automated test suite ($ make test) executes successfully.
  • The automated code linting ($ make lint) executes successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant