session info got wiped out in google passport callback #281
Description
I am using node passport-google-oauth module and trying to redirect the page back to the original path after successful authentication using a session based approach. However, I find when the callback uri was reached, the redirect info stored in session was always wiped out so I was forced to redirect to a default ('/' in this case). Not sure if it's a bug or "expected" behavior. If it's the later, is there a way to redirect it to the original page?
// code snippet
var express = require('express'),
[sic]
passport = require('passport'),
GoogleStrategy = require('passport-google-oauth').OAuth2Strategy,
cookieParser = require('cookie-parser'),
expressSession = require('express-session'),
bodyParser = require('body-parser');
passport.serializeUser(function(user, done) {
done(null, user);
});
passport.deserializeUser(function(obj, done) {
done(null, obj);
});
passport.use(new GoogleStrategy({
clientID: GOOGLE_CLIENT_ID,
clientSecret: GOOGLE_CLIENT_SECRET,
callbackURL: 'http://' + HOST + '/auth/google/callback',
},
function(accessToken, refreshToken, profile, done) {
process.nextTick(function() {
console.log('Profile:' + profile);
return done(null, profile);
});
}
));
var auth = function(req, res, next){
if (!req.session.user) {
console.log('Storing url: ' + req.url);
req.session.returnTo = req.url;
res.redirect('/auth/google');
} else if (!userIsValid(req.session.user)) {
// handle invalid user
} else {
next();
}
};
app.get('/auth/google', function(req, res, next) {
console.log("in /auth/google, returnTo = " + req.session.returnTo);
passport.authenticate('google',
{
scope: ['https://www.googleapis.com/auth/userinfo.profile',
'https://www.googleapis.com/auth/userinfo.email']
}
)(req, res, next)
}
);
app.get('/auth/google/callback', function(req, res, next) {
// req.session.returnTo is wiped out when this is called
console.log("in /auth/google/callback, returnTo = " + req.session.returnTo);
passport.authenticate('google', function(err, user, info) {
console.log("in /auth/google/callback callback");
if (err || !user) {
res.redirect('/auth/google');
} else {
var returnTo = req.session.returnTo ? req.session.returnTo : '/';
delete req.session.returnTo;
console.log('Redirecting to: ' + returnTo);
req.session.user = user;
res.redirect(returnTo);
}
})(req, res, next);
});