Add profile test cases.

Author: jaredhanson

lib/oauth2.js

@@ -89,7 +89,7 @@ Strategy.prototype.userProfile = function(accessToken, done) {
   // TODO: Switch to new URL:
   // https://www.googleapis.com/oauth2/v3/userinfo
   this._oauth2.get(this._userProfileURL, accessToken, function (err, body, res) {
-    if (err) { return done(new InternalOAuthError('failed to fetch user profile', err)); }
+    if (err) { return done(new InternalOAuthError('Failed to fetch user profile', err)); }
 
     try {
       var json = JSON.parse(body)
@@ -102,7 +102,7 @@ Strategy.prototype.userProfile = function(accessToken, done) {
 
       done(null, profile);
     } catch(e) {
-      done(e);
+      return done(new InternalOAuthError('Failed to parse user profile', err));
     }
   });
 }

test/strategy.profile.test.js

@@ -0,0 +1,164 @@
+/* global describe, it, before, expect */
+/* jshint expr: true */
+
+var GoogleStrategy = require('../lib/oauth2');
+
+
+describe('Strategy#userProfile', function() {
+    
+  describe('fetched from Google+ API', function() {
+    var strategy = new GoogleStrategy({
+        clientID: 'ABC123',
+        clientSecret: 'secret',
+        userProfileURL: 'https://www.googleapis.com/plus/v1/people/me'
+      }, function() {});
+  
+    strategy._oauth2.get = function(url, accessToken, callback) {
+      if (url != 'https://www.googleapis.com/plus/v1/people/me') { return callback(new Error('incorrect url argument')); }
+      if (accessToken != 'token') { return callback(new Error('incorrect token argument')); }
+    
+      var body = '{ \
+ "kind": "plus#person",\
+ "occupation": "Software Engineer",\
+ "gender": "male",\
+ "emails": [\
+  {\
+    "value": "example@gmail.com",\
+    "type": "account"\
+  }\
+ ],\
+ "urls": [\
+  {\
+   "value": "http://www.jaredhanson.net/",\
+   "type": "otherProfile",\
+   "label": "Jared Hanson"\
+  }\
+ ],\
+ "objectType": "person",\
+ "id": "111111111111111111111",\
+ "displayName": "Jared Hanson",\
+ "name": {\
+  "familyName": "Hanson",\
+  "givenName": "Jared"\
+ },\
+ "url": "https://plus.google.com/+JaredHanson",\
+ "image": {\
+  "url": "https://lh5.googleusercontent.com/-AAAAA-AAAAA/AAAAAAAAAAA/AAAAAAAAAAA/AAAAAAAAAAA/photo.jpg?sz=50",\
+  "isDefault": false\
+ },\
+ "organizations": [\
+  {\
+   "name": "South Dakota School of Mines & Technology",\
+   "type": "school",\
+   "primary": false\
+  }\
+ ],\
+ "placesLived": [\
+  {\
+   "value": "Berkeley, CA",\
+   "primary": true\
+  }\
+ ],\
+ "isPlusUser": true,\
+ "language": "en",\
+ "circledByCount": 77,\
+ "verified": false\
+}';
+      callback(null, body, undefined);
+    };
+    
+    
+    var profile;
+    
+    before(function(done) {
+      strategy.userProfile('token', function(err, p) {
+        if (err) { return done(err); }
+        profile = p;
+        done();
+      });
+    });
+    
+    it('should parse profile', function() {
+      expect(profile.provider).to.equal('google');
+      
+      expect(profile.id).to.equal('111111111111111111111');
+      expect(profile.displayName).to.equal('Jared Hanson');
+      expect(profile.name.familyName).to.equal('Hanson');
+      expect(profile.name.givenName).to.equal('Jared');
+      expect(profile.emails[0].value).to.equal('example@gmail.com');
+      expect(profile.emails[0].type).to.equal('account');
+      expect(profile.photos[0].value).to.equal('https://lh5.googleusercontent.com/-AAAAA-AAAAA/AAAAAAAAAAA/AAAAAAAAAAA/AAAAAAAAAAA/photo.jpg?sz=50');
+    });
+    
+    it('should set raw property', function() {
+      expect(profile._raw).to.be.a('string');
+    });
+    
+    it('should set json property', function() {
+      expect(profile._json).to.be.an('object');
+    });
+  });
+  
+  describe('error caused by malformed response', function() {
+    var strategy =  new GoogleStrategy({
+        clientID: 'ABC123',
+        clientSecret: 'secret'
+      }, function() {});
+  
+    strategy._oauth2.get = function(url, accessToken, callback) {
+      var body = 'Hello, world.';
+      callback(null, body, undefined);
+    };
+    
+    
+    var err, profile;
+    
+    before(function(done) {
+      strategy.userProfile('token', function(e, p) {
+        err = e;
+        profile = p;
+        done();
+      });
+    });
+  
+    it('should error', function() {
+      expect(err).to.be.an.instanceOf(Error);
+      expect(err.message).to.equal('Failed to parse user profile');
+    });
+  }); // error caused by malformed response
+  
+  describe('internal error', function() {
+    var strategy =  new GoogleStrategy({
+        clientID: 'ABC123',
+        clientSecret: 'secret'
+      }, function verify(){});
+    
+    strategy._oauth2.get = function(url, accessToken, callback) {
+      return callback(new Error('something went wrong'));
+    }
+    
+    
+    var err, profile;
+    
+    before(function(done) {
+      strategy.userProfile('token', function(e, p) {
+        err = e;
+        profile = p;
+        done();
+      });
+    });
+    
+    it('should error', function() {
+      expect(err).to.be.an.instanceOf(Error);
+      expect(err.constructor.name).to.equal('InternalOAuthError');
+      expect(err.message).to.equal('Failed to fetch user profile');
+      expect(err.oauthError).to.be.an.instanceOf(Error);
+      expect(err.oauthError.message).to.equal('something went wrong');
+    });
+    
+    it('should not load profile', function() {
+      expect(profile).to.be.undefined;
+    });
+  }); // internal error
+  
+});