glob('**') returns all files and directories

[jaraco]

A further bug is that glob('**') in zipp returns all files and directoreis, while pathlib.Path.glob('**') returns only directories.

Originally posted by @nh2 in #98 (comment)

[jaraco]

That's interesting, because glob.glob('**') returns files and directories, and the docs for pathlib.glob are unclear on the meaning of **. Probably zipp.Path should align with pathlib conventions, but only where they're by design and not themselves an undefined

[nh2]

the docs for pathlib.glob are unclear on the meaning of **

You are right, and it gets even more confusing:

• glob.glob('**') returns dirs and files, non-recursively, not including .
• glob.glob('**', recursive=True) returns dirs and files, recursively, not including .
• list(pathlib.Path('.').glob('**')) returns only dirs, recursively, and also includes .

I think there should be a Python upstream issue to document all of that, including the differences between glob and pathlib.

Then zipp could implement what's documented for pathlib.

Repro

Python 3.10.11

mkdir -p dir/subdir ; touch toplevel.txt dir/indir.txt

creates:

toplevel.txt
dir/
  indir.txt
  subdir/

>>> import glob, pathlib

>>> glob.glob('**')
['dir', 'toplevel.txt']

>>> glob.glob('**', recursive=True)
['dir', 'dir/subdir', 'dir/indir.txt', 'toplevel.txt']

>>> list(pathlib.Path('.').glob('**'))
[PosixPath('.'), PosixPath('dir'), PosixPath('dir/subdir')]

[jaraco]

@nh2, since a lot of work has been done upstream to clarify the behavior, intent, and exceptions, would you be willing to review the state of the art for CPython (pathlib) and make a recommendation for what behaviors would be best for zipp.Path/zipfile.Path?

[nh2]

I would like to, but I expect that this month I'll be completely out of time.

[jaraco]

Sounds good. I'll assign it to you but also flag it up for others to consider. Take your time and come back to it when you're up for it. If someone else wants to help, please comment here first.

[barneygale]

pathlib.Path.glob('**') returns both files and directories as of Python 3.13, so I think this bug is invalid.

[jaraco]

The current implementation brings its own glob implementation. Barney, do you have any interest in unifying the implementations?

[barneygale]

I'm very interested in that :-) in fact I've been working on a little proof-of-concept in the background, which is why I logged a few zipp issues lately