-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
disable_error_code = import-untyped
in mypy.ini
#142
Conversation
Use imperative voice and orient the comment to describe the setting more directly and give guidance on what to do about it.
Thanks! I'm thinking that since some of the projects no longer need this setting, I might merge it to a separate branch and only merge that branch into the projects that are failing. I'm not quite sure how to do that yet. |
I've squash-merged the change to the |
Initial indications are that this helps modestly, but also is going to mask the underlying concern. That is, eventually someone is going to have to come along and disable this setting to find out what is still failing. Granted, one could do that in 2-3 years after presumably some of these upstream packages have supplied the types and thus the root issue is solved. But unless the upstream projects are informed of the need, that may never happen. Given that this issue is likely only a partial fix, I'm almost more inclined to take more drastic measures like disabling mypy checks for the affected projects. It would be nice if there was a way to turn them into warnings instead of errors, so that the test suite could proceed, and the failures would reported but non-blocking. |
As discussed in #143, we're deferring this change and instead disabling mypy for now. |
…d simpler relevant comments. Ref #142
…lso required for clean diffs. Ref #142
@jaraco This is a global solution I suggested to reduce a lot of churn and time-consuming changes left as mentioned in #136 (comment)
Projects that already started doing:
can keep those entries exactly the way they already are w/o issue.
Projects that have yet to identify their untyped dependencies will see a lot less sudden type errors.
This is directly related to #98 (comment)