Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move .coveragerc into pyproject.toml #14

Closed
brettcannon opened this issue Mar 21, 2020 · 3 comments
Closed

Move .coveragerc into pyproject.toml #14

brettcannon opened this issue Mar 21, 2020 · 3 comments

Comments

@brettcannon
Copy link
Contributor

Might as well cut out a file. 😄

https://coverage.readthedocs.io/en/coverage-5.0.4/config.html

@jaraco
Copy link
Owner

jaraco commented May 20, 2020

Hmm. I've historically let each tool prefer its own file, in part because it serves as a signal to someone inspecting the project that the tool is used, but also to provide for separation of concerns. It's also the only approach that I'm able to apply consistently. For example, pytest allows use of pytest.ini, tox.ini, or setup.cfg. flake8 honors some files like setup.cfg and pyproject.toml. Chosing the project's preferred config file seems like the best approach to apply consistently. It seems to me a fool's errand to arbitrarily choose one over another, especially piecemeal. How about we defer this tweak until there's documented guidance or consensus that pyproject.toml is the preferred file for all config for all tools, and then do it with all the tools that support it?

@brettcannon
Copy link
Contributor Author

Flake8 actually doesn't use pyproject.toml.

And fair enough! I don't think you will ever get documented guidance but possibly consensus.

@jaraco
Copy link
Owner

jaraco commented May 23, 2020

I should say too, I'm happy for skeleton and its derivative projects to be helping drive the consensus and not just following. I just want to avoid making capricious changes.

@jaraco jaraco closed this as completed Aug 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants