Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's the best URL for the GitHub repo? #129

Closed
jaraco opened this issue Jun 21, 2024 · 3 comments
Closed

What's the best URL for the GitHub repo? #129

jaraco opened this issue Jun 21, 2024 · 3 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Jun 21, 2024

Today I learned that my projects are unavailable on tea.xyz due to their GitHub url being found in the Homepage key, leading to this error:

image

It used to be the case that tea supported the Homepage key, but that led to problems because that value was used very loosely, sometimes pointing to subpaths within the project like the README or folder within the repo.

Therefore, they search for Source, which seems to be the most popular place to reliably configure a GitHub URL, despite other resources indicating repository.

Let's update the label to use "Source" for better clarity and to align with tea.xyz.

@jaraco
Copy link
Owner Author

jaraco commented Jun 21, 2024

I've drafted a fix (simply replacing the name), but this change creates a merge conflict with every downstream repo and the jaraco.develop known-merge tool doesn't yet support it, so it's going to need more support before it can be merged.

@jaraco
Copy link
Owner Author

jaraco commented Jun 21, 2024

Dang. So when these placeholders are in the README, the merge routine works fine to re-substitute the placeholders. But when the conflict is in the pyproject.toml, the routine is unable to load the project metadata because the syntax of that file is broken by the conflict.

And because of the way the merge tool works, the routine is only called after the conflict is already manifest, so there's no great hook point to extract the metadata before the conflict is manifest.

@jaraco
Copy link
Owner Author

jaraco commented Jun 21, 2024

Okay. I've worked out the issue with the merge routine and it's now successfully resolving merges that alter lines in substitutions. It should now be possible to apply the change to the skeleton and roll it out across the projects.

@jaraco jaraco closed this as completed in c9729e1 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant