Skip to content
This repository has been archived by the owner on Dec 19, 2023. It is now read-only.

Provide values override for global.clusterRouterBase #4

Closed
Tracked by #19
tumido opened this issue Sep 5, 2023 · 1 comment · Fixed by #11
Closed
Tracked by #19

Provide values override for global.clusterRouterBase #4

tumido opened this issue Sep 5, 2023 · 1 comment · Fixed by #11
Assignees
Labels
kind/enhancement New feature or request

Comments

@tumido
Copy link
Member

tumido commented Sep 5, 2023

In the helm chart install instructions we require the following step:

https://github.com/janus-idp/helm-backstage/tree/main/charts/backstage#installing-from-the-chart-repository

When installed on OpenShift via this operator, this should be automated:

  1. Make the operator fetch oc get ingresses.config/cluster -o jsonpath={.spec.domain}
  2. Provide this via reconciler.WithOverrideValues

Please make the operator to always enforce this value to be in sync with the cluster - The operator doesn't need to watch the ingresses.config/cluster resource, but it should fetch the correct value on every helm upgrade.

@tumido tumido added the kind/enhancement New feature or request label Sep 5, 2023
@kadel kadel self-assigned this Sep 6, 2023
@kadel
Copy link
Member

kadel commented Sep 8, 2023

2. Provide this via reconciler.WithOverrideValues

I'm not sure if using WithOverridValues is the right thing. With this approach, the values will only be updated when the operator starts. I'm unable to figure out how to update values for WithOverridValues on every helm upgrade.

I think that there should be a little bit more than just simply overriding global.clusterRouterBase.

For example, users might want to set their own custom clusterRouterBase that doesn't match the default Ingress domain.
I'm considering the approach where global.clusterRouterBase is set only when the user has not set it explicitly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants