Merge pull request #1 from jamjon3/develop

Switching this to multistage docker build

Author: jamjon3

Dockerfile

@@ -1,4 +1,4 @@
-FROM registry.fedoraproject.org/fedora:latest
+FROM registry.fedoraproject.org/fedora:latest AS base
 
 LABEL maintainer="James Jones <jamjon3@gmail.com>"
 LABEL description="This project illustrates a python app that uses an API \
@@ -7,6 +7,9 @@ to derive a download URL and download the target file."
 # Install some dependencies
 RUN dnf install -y rubygems ruby-devel gcc gcc-c++ make \
             libffi-devel python3 python3-pip python3-virtualenv python-unversioned-command
+
+FROM base AS build
+
 WORKDIR /output
 
 # Copy over python related files
@@ -24,13 +27,10 @@ RUN source venv/bin/activate \
 RUN source venv/bin/activate \
     && exec python build.py
 
-# Move the binary into /usr/bin
-RUN mv dist/getlatestdownloadbinary /usr/bin/getlatestdownloadbinary
+FROM base AS final
 
-WORKDIR /
-
-# Clear out all the build files and virtual environment for Python
-RUN rm -Rf /output
+# Move the binary into /usr/bin
+COPY --from=build --chown=root:root /output/dist/getlatestdownloadbinary /usr/bin/getlatestdownloadbinary
 
 # Setup the entrypoint script
 COPY entrypoint.sh /usr/bin/

README.md

@@ -23,7 +23,7 @@ as well as another small class for downloading te release binary.
 Uses a docker container to 'build' the 'Option 1' basic app into a binary inside a container
 using:
 
-```docker build --tag sample  .```
+```docker build --target final --tag sample .```
 
 This builds a container with the PyInstaller binary setup with an entrypoint
 so it can be executed without specifying the binary:

version.py

@@ -1 +1 @@
-__version__ = '1.0.0'
+__version__ = '1.0.1'