Updated componentWillMount to componentDidMount by Daggron · Pull Request #220 · jamiebuilds/react-loadable

Daggron · 2019-12-17T12:44:51Z

I was using this in my project and i saw its using componentWillMount which will be deprected in the new version of react so i updated it with componentDidMount. To avoid deprecation and remove the warning

pixmaster · 2020-01-10T15:10:41Z

src/index.js

    }

-    componentWillUnmount() {
+    componentDidUnmount() {


As I understand, componentWillUnmount wasn't deprecated, only componentWillMount.

BTW componentDidUnmount non-existent method

Okay , Sir I will change it

Sir i have changed the method back to componentWillUnmount

stonecrafter · 2020-01-16T15:33:00Z

Also interested in this change 🎉

brendonco · 2020-01-22T10:09:29Z

Any plan on merging this PR? and release date?

alirizvi2008 · 2020-01-27T14:39:36Z

Can someone help merge this PR and publish the lib :)

dabyland · 2020-02-04T15:32:48Z

Seems like a very small change for this codebase, would love to see it merged and published soon!

viiiprock · 2020-02-04T23:52:11Z

Guys, I considered react-loadable has not been maintaining, please migrate to other package such as react-imported-component, loadable-component...
Good luck.

goldenshooter · 2020-02-08T04:30:11Z

Anyone can merge this PR? I got same warning.

alex-zhang · 2020-02-09T16:29:34Z

same warning. any update?

mouhsnimohamed · 2020-02-11T10:46:37Z

why this PR wont be merged?

dabyland · 2020-02-17T13:52:17Z

I don't mean to harp on this pull request but it's a one line change that has been open for 2 months with no update. Can we please have some communication for the cause of the hold up?

Thanks!

* upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

INSPIR-3203 * upgrades to antd to v4 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800

* upgrades to antd to v4 * fixes UX problems with date range picker: INSPIR-3203 * reduces bundle size by removing unnecessary icons: INSPIR-3228 * upgrades to react@16.13.10 * upgrades to react-router to v5 Unresolved: * `componentWillReceiveProps` warnings from `react-vis` uber/react-vis#1253 * search name space truncates some options like `conferen...` ant-design/ant-design#21754 * `componentWillMount` warnings from `react-helmet` nfl/react-helmet#413 * `componentWillMount` warnings from `react-loadable` jamiebuilds/react-loadable#220 * `Cannot update a component from inside the function body of a different component.` worning from `antd` ant-design/ant-design#21800 * `componentWillReceiveProps` warnings from `react-quill` zenoamaro/react-quill#549

p0o · 2020-03-20T12:38:36Z

Hi all, I put the fixed version with addition of build files in my github repo so you can change your npm package to this if you need a quick fix.

should look like this in package.json:

"react-loadable": "github:p0o/react-loadable",

cnscorpions · 2020-05-27T08:59:27Z

@p0o it works, thanks. I cloned this repo, and found "yarn start" not work at all.

p0o · 2020-05-27T10:25:47Z

@cnscorpions I think I built it with npm.

darcyadams · 2020-07-24T17:13:15Z

So it is clear that we will be migrating off react-loadable at some point. I certainly understand the challenges of donating your time to an open source project.
However, those of us in larger projects can't necessarily do that immediately. We also can't cutover to a random github fork, as there is no guarantee that won't change or disappear.
So, in the meantime, we would really appreciate it if the maintainers of this repo could take the few minutes it would take to merge this PR and publish a new patch version to npm. 🙏
Thanks for your time and for building this very useful tool.

p0o · 2020-07-26T05:01:08Z

So it is clear that we will be migrating off react-loadable at some point. I certainly understand the challenges of donating your time to an open source project.
However, those of us in larger projects can't necessarily do that immediately. We also can't cutover to a random github fork, as there is no guarantee that won't change or disappear.
So, in the meantime, we would really appreciate it if the maintainers of this repo could take the few minutes it would take to merge this PR and publish a new patch version to npm. 🙏
Thanks for your time and for building this very useful tool.

Suggestion: You can fork my repo up there into your github organization or publish your npm package if you need a more reliable solution.

slorber · 2021-02-12T15:08:28Z

For anyone interested, here's my solution to get rid of the warning (React 16 + 17) and still get this working (client+SSR).

#213 (comment)

Updated componentWillMount to componentDidMount

18de9a4

pixmaster reviewed Jan 10, 2020

View reviewed changes

chnaged back to component will unmount

9960390

alex-zhang mentioned this pull request Mar 30, 2020

componentWillMount removed #227

Open

Repository owner deleted a comment from ygs-code Sep 6, 2022

Conversation

Daggron commented Dec 17, 2019

Uh oh!

pixmaster Jan 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Daggron Jan 11, 2020

Choose a reason for hiding this comment

Uh oh!

Daggron Jan 11, 2020

Choose a reason for hiding this comment

Uh oh!

stonecrafter commented Jan 16, 2020

Uh oh!

brendonco commented Jan 22, 2020

Uh oh!

alirizvi2008 commented Jan 27, 2020

Uh oh!

dabyland commented Feb 4, 2020

Uh oh!

viiiprock commented Feb 4, 2020

Uh oh!

goldenshooter commented Feb 8, 2020

Uh oh!

alex-zhang commented Feb 9, 2020

Uh oh!

mouhsnimohamed commented Feb 11, 2020

Uh oh!

dabyland commented Feb 17, 2020

Uh oh!

p0o commented Mar 20, 2020

Uh oh!

cnscorpions commented May 27, 2020

Uh oh!

p0o commented May 27, 2020

Uh oh!

darcyadams commented Jul 24, 2020

Uh oh!

p0o commented Jul 26, 2020

Uh oh!

slorber commented Feb 12, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

pixmaster Jan 10, 2020 •

edited

Loading