From 58c593120e54c7c8750acb1352cb38804d880764 Mon Sep 17 00:00:00 2001 From: zht96830 Date: Mon, 15 Apr 2019 14:19:49 +0800 Subject: [PATCH 1/2] Update Statistics Trend error message for maximum periods. Updated User Guide to reflect change. Update PPP --- docs/UserGuide.adoc | 2 +- docs/team/zht96830.adoc | 1 + src/main/java/seedu/address/model/statistics/Statistics.java | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/UserGuide.adoc b/docs/UserGuide.adoc index d4c66971f867..4bb72b916130 100644 --- a/docs/UserGuide.adoc +++ b/docs/UserGuide.adoc @@ -557,7 +557,7 @@ Format: `statstrend sd/START_DATE ed/END_DATE f/FREQUENCY` [NOTE] ==== * START_DATE should be before END_DATE -* A maximum of 10 periods will be displayed. Please enter different variables to see Statistics that are truncated. +* A maximum of 10 periods will be displayed. Please enter different variables to see Statistics beyond the first 10 shown. * The statistics displayed are only correct at the time of command execution. If any commands which modify the state of the Financial Tracker are added, the command has to be activated again for accurate statistics to be shown ==== diff --git a/docs/team/zht96830.adoc b/docs/team/zht96830.adoc index ce7c92d9bf89..5063fde40107 100644 --- a/docs/team/zht96830.adoc +++ b/docs/team/zht96830.adoc @@ -37,6 +37,7 @@ Personal Finance Tracker is a desktop finance tracker application used for track *** Update logic component in Developer's Guide (Pull Request https://github.com/CS2103-AY1819S2-W15-2/main/pull/108[108], https://github.com/CS2103-AY1819S2-W15-2/main/pull/110[110]) *** Update commands to work for the Financial Tracker (Pull Request https://github.com/CS2103-AY1819S2-W15-2/main/pull/83[83], https://githubcom/CS2103-AY1819S2-W15-2/main/pull/88[88], https://github.com/CS2103-AY1819S2-W15-2/main/pull/96[96],...) *** Added the implementation of statistics in Developer's Guide (Pull Request https://github.com/CS2103-AY1819S2-W15-2/main/pull/225[225], https://github.com/CS2103-AY1819S2-W15-2/main/pull/281[281]) +*** Added test cases for Statistics class (https://github.com/CS2103-AY1819S2-W15-2/main/pull/287[287]) == Contributions to the User Guide diff --git a/src/main/java/seedu/address/model/statistics/Statistics.java b/src/main/java/seedu/address/model/statistics/Statistics.java index e0b6280be64d..bbd8ac4006c4 100644 --- a/src/main/java/seedu/address/model/statistics/Statistics.java +++ b/src/main/java/seedu/address/model/statistics/Statistics.java @@ -222,7 +222,7 @@ private void trendStats(Date startDate, Date endDate, Frequency frequency) { if (intervalCount == 10) { this.html = html + "
\n" - + "Maximum periods of 10 reached!
"; + + "Maximum periods of 10 reached! Only the first 10 periods will be shown.
"; } this.html = html + "
" From 957b39f6bbca27192f696360c45831a6b4cef906 Mon Sep 17 00:00:00 2001 From: zht96830 Date: Mon, 15 Apr 2019 14:30:02 +0800 Subject: [PATCH 2/2] Update PPP --- docs/team/zht96830.adoc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/team/zht96830.adoc b/docs/team/zht96830.adoc index 5063fde40107..e38e465609c3 100644 --- a/docs/team/zht96830.adoc +++ b/docs/team/zht96830.adoc @@ -19,7 +19,7 @@ Personal Finance Tracker is a desktop finance tracker application used for track ** Justification: This feature improves the product significantly because a user can now understand their spending habits at a glance ** Highlights: This feature allows a user to see what percentage of their expenses are spent on a particular category. The user can also quickly see how often they are spending through the expense counts. -* *Code contributed*: [https://nus-cs2103-ay1819s2.github.io/cs2103-dashboard/#search=zht96&sort=displayName&since=2019-02-10&until=2019-03-26&timeframe=day&reverse=false&repoSort=true[code collated by reposense]] +* *Code contributed*: https://nus-cs2103-ay1819s2.github.io/cs2103-dashboard/#search=zht968&sort=displayName&since=2019-02-10&until=2019-04-15&timeframe=day&reverse=false&repoSort=true[code collated by reposense]] * *Other contributions*: