Hack together way of making ghost pointer reappear in correct location

Author: jamesshore

src/server/_real_time_logic_test.js

@@ -109,7 +109,7 @@
 				});
 			});
 
-			it("redisplays ghost pointer when client has activity after timeout", function() {
+			it("redisplays ghost pointer when client receives draw message after timeout", function() {
 				const clientId = "my client ID";
 				realTimeServer.connectNullClient(clientId);
 
@@ -120,18 +120,17 @@
 					serverMessages.push(message);
 				});
 
-				// can't use pointer message because that's what we're looking for
-				const clientMessage = new ClientDrawMessage(10, 20, 30, 40);
-				realTimeServer.simulateClientMessage(clientId, clientMessage);
+				const drawMessage = new ClientDrawMessage(10, 20, 30, 40);
+				realTimeServer.simulateClientMessage(clientId, drawMessage);
 
 				assert.deepEqual(serverMessages, [
 					{
-						message: new ServerPointerMessage(clientId, 42, 42),
+						message: new ServerPointerMessage(clientId, 30, 40),    // should appear in correct location
 						type: RealTimeServer.SEND_TYPE.ALL_CLIENTS_BUT_ONE,
 						clientId,
 					},
 					{
-						message: clientMessage.toServerMessage(clientId),
+						message: drawMessage.toServerMessage(clientId),
 						type: RealTimeServer.SEND_TYPE.ALL_CLIENTS_BUT_ONE,
 						clientId,
 					}

src/server/real_time_logic.js

@@ -4,6 +4,7 @@
 
 	const ServerRemovePointerMessage = require("../shared/server_remove_pointer_message.js");
 	const ServerPointerMessage = require("../shared/server_pointer_message.js");
+	const ClientDrawMessage = require("../shared/client_draw_message.js");
 	const MessageRepository = require("./message_repository.js");
 	const Clock = require("./clock.js");
 	const RealTimeServer = require("./real_time_server.js");
@@ -66,10 +67,13 @@
 			resetClientTimeout(clientId);
 		}
 
-		function updateClient({ clientId }) {
+		function updateClient({ clientId, message }) {
 			if (!isTrackingClient(clientId)) {
 				startTrackingClient(clientId);
-				broadcastAndStoreMessage(self, clientId, new ServerPointerMessage(clientId, 42, 42));
+				if (message.name() === ClientDrawMessage.MESSAGE_NAME) {
+					const data = message._data;
+					broadcastAndStoreMessage(self, clientId, new ServerPointerMessage(clientId, data.toX, data.toY));
+				}
 			}
 			else {
 				resetClientTimeout(clientId);

todo.txt

@@ -57,5 +57,10 @@ Engineering Tasks:
 
 To Do on current task:
 * Make the pointer show up in the right spot
+	* DrawMessage
+		- fix internal variable hack
+	- ClearScreenMessage
+	- PointerMessage
+	- RemovePointerMessage
 - What's the best way to handle our ordering issues (currently we work around it by just calling trackClientTimeout() first)
 - Factor out code to track server messages