Add 'no-invalid-this' ESLint rule

Author: jamesshore

Jakefile.js

@@ -74,6 +74,7 @@
 	createDirectoryDependencies(paths.lintDirectories());
 
 	rule(".lint", determineLintDependency, function() {
+		/*eslint no-invalid-this:off */
 		var lint = require("./build/util/lint_runner.js");
 		var lintConfig = require("./build/config/eslint.conf.js");
 

build/config/eslint.conf.js

@@ -58,6 +58,7 @@
 			"no-global-assign": ERROR,
 			"no-implicit-globals": ERROR,
 			"no-implied-eval": ERROR,
+			"no-invalid-this": ERROR,
 			"no-iterator": ERROR,
 			"no-loop-func": ERROR,
 			"no-octal": ERROR,

src/_release_test.js

@@ -12,6 +12,7 @@
 	var assert = require("_assert");
 
 	describe("Release", function() {
+		/*eslint no-invalid-this:off */
 		this.timeout(10 * 1000);
 
 		it("is on web", function(done) {

src/_smoke_test.js

@@ -27,6 +27,7 @@
 	var driver;
 
 	describe("Smoke test", function() {
+		/*eslint no-invalid-this:off */
 		this.timeout(30 * 1000);
 
 		before(function (done) {

src/client/content/_404_test.js

@@ -18,6 +18,7 @@
 		var drawSomething;
 
 		before(function(done) {
+			/*eslint no-invalid-this:off */
 			this.timeout(10 * 1000);
 			var options = {
 				src: "/base/src/client/content/404.html",

src/client/content/_index_test.js

@@ -21,6 +21,7 @@
 		var joinUs;
 
 		before(function(done) {
+			/*eslint no-invalid-this:off */
 			this.timeout(10 * 1000);
 			var options = {
 				src: "/base/src/client/content/index.html",

src/client/ui/html_element.js

@@ -1,5 +1,6 @@
 // Copyright (c) 2013-2016 Titanium I.T. LLC. All rights reserved. See LICENSE.txt for details.
 /*global $, jQuery */
+/*eslint no-invalid-this:off */   // event handlers set 'this'
 
 (function() {
 	"use strict";

todo.txt

@@ -62,9 +62,8 @@ Engineering Tasks:
 - Test that client and server talk to each other correctly; not just that they can talk to Socket.IO, but specifically that they talk to each other
 
 To Do on current task:
-- OFF-CAMERA:
+- DONE OFF-CAMERA:
 	- Rename 'Event' to 'Message' across the board
-- BEFORE EPISODE:
 	- Add 'no-invalid-this' linter rule (thanks to Martin Grandrath)
 - Look for opportunities to improve Socket.IO abstraction API
 	- Unify event sending parameters as suggested by Martin Grandrath's in E582 comments - http://www.letscodejavascript.com/v3/comments/live/582#comment-3675682857