Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds option to specify the target file #79

Merged
merged 7 commits into from
May 31, 2023

Conversation

Lissy93
Copy link
Contributor

@Lissy93 Lissy93 commented Apr 19, 2022

Hi @jamesgeorge007 👋
Love your action, it's been very useful :)

Re issue: #68, #48, #56

This PR implements the option to use a file other than the readme, by specifying a TARGET_FILE.
If it isn't specified, it will continue to use README.md, so is fully backwards compatible.

Let me know if there's anything you'd like me to change,
Have a great day!

@fbuireu
Copy link

fbuireu commented May 2, 2022

It seems to be only detecting changes in the README.md file. Have you tested it?

In my case, I have a loop to target different README.md files as a TARGET_FILE (which is targeting the correct TARGET_FILE) but I've also tried it using an isolated action (see https://github.com/fbuireu/fbuireu/runs/6252387075?check_suite_focus=true) or the following screenshot:

image

In this case, README.es.md is far way not updated and different from the README.md but it's outputting "no changes detected".

@Lissy93
Copy link
Contributor Author

Lissy93 commented May 2, 2022

Have you tested it?

Yeah, I'm running it in this workflow run.
Which is defined in workflows/recent-activity.yml and is updating Lissy93/RECENT-ACTIVITY.md.
It seems to be working just fine, but I'm pretty new to GitHub actions, so I could be missing something?

workflow-run

@fbuireu
Copy link

fbuireu commented May 2, 2022

I think you are missing the changes in the distribution file (https://github.com/Lissy93/github-activity-readme/blob/master/dist/index.js).

I've forked your repo to apply the required changes (based on this PR) but I'm not able to make you a PR because the upstream is gone and I don't want to create another PR either because you earnt the credit.

It seems to work on my custom GitHub action right now. If you want to update the distribution index.js based on mine here it is: https://github.com/fbuireu/github-activity-readme

By the way, thanks for the PR and the effort :)

@Lissy93
Copy link
Contributor Author

Lissy93 commented May 2, 2022

@fbuireu, you're totally right, thanks for explaining :)
Dumb mistake on my part, I've updated it now, tested and seems to be working

@Lissy93
Copy link
Contributor Author

Lissy93 commented Jul 21, 2022

@jamesgeorge007 - Project still alive?
It's nice work on your part, and your GH action seems to have been very popular with the community.
So it would be good to get some updates pushed out, PRs reviewed / coded, or a note about weather it's still maintained.

@jamesgeorge007
Copy link
Owner

@Lissy93, thank you so much for the kind words, and my apologies for the delayed response. I'd love to see this project going ahead. Unfortunately, I'm short on bandwidth currently. May I know if you are interested in being a collaborator?

@tuunit tuunit changed the base branch from master to 0.4.0-rc May 31, 2023 07:29
@tuunit tuunit merged commit a4530d8 into jamesgeorge007:0.4.0-rc May 31, 2023
@tuunit tuunit mentioned this pull request May 31, 2023
tuunit added a commit that referenced this pull request May 31, 2023
Co-authored-by: Jan Larwig <jan@larwig.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
tuunit added a commit to tuunit/github-activity-readme that referenced this pull request May 31, 2023
Co-authored-by: Jan Larwig <jan@larwig.com>
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants