-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Adds option to specify the target file #79
Conversation
It seems to be only detecting changes in the In my case, I have a loop to target different In this case, |
Yeah, I'm running it in this workflow run. |
I think you are missing the changes in the distribution file (https://github.com/Lissy93/github-activity-readme/blob/master/dist/index.js). I've forked your repo to apply the required changes (based on this PR) but I'm not able to make you a PR because the upstream is gone and I don't want to create another PR either because you earnt the credit. It seems to work on my custom GitHub action right now. If you want to update the distribution By the way, thanks for the PR and the effort :) |
@fbuireu, you're totally right, thanks for explaining :) |
@jamesgeorge007 - Project still alive? |
@Lissy93, thank you so much for the kind words, and my apologies for the delayed response. I'd love to see this project going ahead. Unfortunately, I'm short on bandwidth currently. May I know if you are interested in being a collaborator? |
Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: Jan Larwig <jan@larwig.com> Co-authored-by: James George <jamesgeorge998001@gmail.com>
Co-authored-by: Jan Larwig <jan@larwig.com> Co-authored-by: James George <jamesgeorge998001@gmail.com>
Hi @jamesgeorge007 👋
Love your action, it's been very useful :)
Re issue: #68, #48, #56
This PR implements the option to use a file other than the readme, by specifying a
TARGET_FILE
.If it isn't specified, it will continue to use
README.md
, so is fully backwards compatible.Let me know if there's anything you'd like me to change,
Have a great day!