Skip to content

Commit 8244ab6

Browse files
Merge pull request #1 from adamcin/adamcin/mac-arm64-prebuild
changes to get macos prebuild to pass on arm64 local machine
2 parents 0988555 + d857c7a commit 8244ab6

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

.github/workflows/prebuild.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
npm install nan
5252
. prebuild/macOS/preinstall.sh
5353
cp prebuild/macOS/binding.gyp binding.gyp
54-
node-gyp rebuild -j 2 --arch=${{ runner.arch }}
54+
node-gyp rebuild -j 2 --arch=${{ matrix.os.arch }}
5555
. prebuild/macOS/bundle.sh
5656
5757
- name: Test binary

prebuild/macOS/binding.gyp

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@
2323
'defines': [
2424
'HAVE_GIF',
2525
'HAVE_JPEG',
26-
'HAVE_RSVG'
26+
'HAVE_RSVG',
27+
'NAPI_DISABLE_CPP_EXCEPTIONS',
28+
'NODE_ADDON_API_ENABLE_MAYBE'
2729
],
2830
'libraries': [
2931
'<!@(pkg-config pixman-1 --libs)',
@@ -32,18 +34,22 @@
3234
'<!@(pkg-config pangocairo --libs)',
3335
'<!@(pkg-config freetype2 --libs)',
3436
'<!@(pkg-config librsvg-2.0 --libs)',
35-
'-ljpeg',
37+
'<!@(pkg-config libjpeg --libs)',
38+
'-L/opt/homebrew/lib',
3639
'-lgif'
3740
],
3841
'include_dirs': [
39-
'<!(node -e "require(\'nan\')")',
42+
'<!(node -p "require(\'node-addon-api\').include_dir")',
4043
'<!@(pkg-config cairo --cflags-only-I | sed s/-I//g)',
4144
'<!@(pkg-config libpng --cflags-only-I | sed s/-I//g)',
4245
'<!@(pkg-config pangocairo --cflags-only-I | sed s/-I//g)',
4346
'<!@(pkg-config freetype2 --cflags-only-I | sed s/-I//g)',
44-
'<!@(pkg-config librsvg-2.0 --cflags-only-I | sed s/-I//g)'
47+
'<!@(pkg-config librsvg-2.0 --cflags-only-I | sed s/-I//g)',
48+
'/opt/homebrew/include'
4549
],
50+
'cflags+': ['-fvisibility=hidden'],
4651
'xcode_settings': {
52+
'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
4753
'GCC_ENABLE_CPP_EXCEPTIONS': 'YES'
4854
}
4955
}

prebuild/macOS/preinstall.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
brew update
2-
brew install pkg-config cairo pango librsvg python3 giflib # python3 is for macpack
2+
brew install pkg-config cairo pango libpng jpeg giflib librsvg pixman python3 # python3 is for macpack
33
brew upgrade python # activates python 3
44
pip3 install --break-system-packages --user macpack

0 commit comments

Comments
 (0)